Re: [PATCH v4 4/6] sev/i386: Don't allow a system reset under an SEV-ES guest
From: Tom Lendacky <thomas.lendacky@amd.com>
Date: 2021-01-26 16:41:23
Also in:
qemu-devel
On 1/26/21 10:16 AM, Paolo Bonzini wrote:
On 25/09/20 21:03, Tom Lendacky wrote:quoted
{ - if (no_reboot && reason != SHUTDOWN_CAUSE_SUBSYSTEM_RESET) { + if (!cpus_are_resettable()) { + error_report("cpus are not resettable, terminating"); + shutdown_requested = reason; + } else if (no_reboot && reason != SHUTDOWN_CAUSE_SUBSYSTEM_RESET) {The error should not be emitted if "no_reboot && reason != SHUTDOWN_CAUSE_SUBSYSTEM_RESET" (the condition has changed a bit in latest QEMU but the idea is the same). This is because whoever invoked QEMU could already know about this SEV-ES limitation, and use -no-reboot (aka -action reset=shutdown in 6.0) in order to change the forbidden warm reset into a shutdown+restart cold reset.
Ah, right. Let me re-work this to not emit the message when it is not warranted. Thanks, Tom
Paolo