Re: [PATCH v5 2/6] sev/i386: Require in-kernel irqchip support for SEV-ES guests
From: Dr. David Alan Gilbert <hidden>
Date: 2021-01-25 19:18:15
Also in:
qemu-devel
* Tom Lendacky (thomas.lendacky@amd.com) wrote:
From: Tom Lendacky <thomas.lendacky@amd.com> In prep for AP booting, require the use of in-kernel irqchip support. This lessens the Qemu support burden required to boot APs. Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Richard Henderson <richard.henderson@linaro.org> Cc: Eduardo Habkost <redacted> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Reviewed-by: Dr. David Alan Gilbert <redacted> (I'm failing to fidn a definition of irqchip_required vs allowed)
quoted hunk ↗ jump to hunk
--- target/i386/sev.c | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/target/i386/sev.c b/target/i386/sev.c index fce2128c07..ddec7ebaa7 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c@@ -776,6 +776,12 @@ sev_guest_init(const char *id) sev->api_minor = status.api_minor; if (sev_es_enabled()) { + if (!kvm_kernel_irqchip_allowed()) { + error_report("%s: SEV-ES guests require in-kernel irqchip support", + __func__); + goto err; + } + if (!(status.flags & SEV_STATUS_FLAGS_CONFIG_ES)) { error_report("%s: guest policy requires SEV-ES, but " "host SEV-ES support unavailable",-- 2.30.0
-- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK