On Mon, Jan 18, 2021 at 11:22:47AM +0100, Thomas Huth wrote:

On 18/01/2021 11.11, Daniel P. Berrangé wrote:

quoted

On Mon, Jan 18, 2021 at 02:38:08PM +0800, Jiaxun Yang wrote:

quoted

We only run build test and check-acceptance as their are too many
failures in checks due to minor string mismatch.

Can you give real examples of what's broken here, as that sounds
rather suspicious, and I'm not convinced it should be ignored.

I haven't tried, but I guess it's the "check-block" iotests that are likely
failing with a different libc, since they do string comparison on the
textual output of the tests. If that's the case, it would maybe be still ok
to run "check-qtest" and "check-union" on Alpine instead of the whole
"check" test suite.

Perhaps errno strings are different due to libc hitting block tests. I
would expect this to be explained in the commit message though with
example, so we have a clear record of why we needed to disable this.

It might indicate a need to change our test suite to be more robust
in this area, because that would also suggest the tests might fail
on  non-Linux.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|