Re: [PATCH] vfio: fix potential memory leak in vfio_msi_cap_len
From: David Hildenbrand <hidden>
Date: 2018-08-30 14:16:06
Also in:
lkml
On 27.08.2018 14:47, Li Qiang wrote:
quoted hunk ↗ jump to hunk
Free the vdev->msi_perm in error path. Signed-off-by: Li Qiang <redacted> --- drivers/vfio/pci/vfio_pci_config.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c index 115a36f6f403..62023b4a373b 100644 --- a/drivers/vfio/pci/vfio_pci_config.c +++ b/drivers/vfio/pci/vfio_pci_config.c@@ -1180,8 +1180,10 @@ static int vfio_msi_cap_len(struct vfio_pci_device *vdev, u8 pos) return -ENOMEM; ret = init_pci_cap_msi_perm(vdev->msi_perm, len, flags); - if (ret) + if (ret) { + kfree(vdev->msi_perm); return ret; + } return len; }
Doesn't vfio_config_free() take care of that in all cases? -- Thanks, David / dhildenb