On 23/08/2018 10:02, Janosch Frank wrote:

On 22.08.2018 18:53, David Hildenbrand wrote:

quoted

On 22.08.2018 18:51, Pierre Morel wrote:

quoted

Copy the key mask to the right offset inside the shadow CRYCB

Signed-off-by: Pierre Morel <redacted>
Reviewed-by: David Hildenbrand <redacted>
---
  arch/s390/kvm/vsie.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
index 9175518..12b9707 100644
--- a/arch/s390/kvm/vsie.c
+++ b/arch/s390/kvm/vsie.c

@@ -173,7 +173,8 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
  		return set_validity_icpt(scb_s, 0x0039U);
  
  	/* copy only the wrapping keys */
-	if (read_guest_real(vcpu, crycb_addr + 72, &vsie_page->crycb, 56))
+	if (read_guest_real(vcpu, crycb_addr + 72,
+			    vsie_page->crycb.dea_wrapping_key_mask, 56))
  		return set_validity_icpt(scb_s, 0x0035U);
  
  	scb_s->ecb3 |= ecb3_flags;

Please fixup the subject as requested. (were there more RB-s?)

Yes, he seems to have ignored mine...

Sorry,
I focused on your comment and the answer from David and forgot it.

thanks Janosch I will add it of course

regards,
Pierre

-- 
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany