On 01/31/2012 09:49 PM, Anthony Liguori wrote:

quoted

+        DEFINE_PROP_HEX32("iobase", PCSpkState, iobase,  -1),
+        DEFINE_PROP_PTR("pit", PCSpkState, pit),

Please don't introduce a pointer property here.  They cannot be used in
a meaningful way in qdev.  Why not register a link<TYPE_PIT> in
instance_init?

I'm going to clean this up, you can leave the PTR for now.

Paolo