On Fri, Feb 03, 2017 at 05:12:37PM -0800, Guru Das Srinagesh wrote:

On 3 February 2017 at 13:25, srishti sharma [off-list ref] wrote:

quoted

okay , Thanks for your reply

On Sat, Feb 4, 2017 at 2:53 AM, Jim Davis [off-list ref] wrote:

quoted

On Fri, Feb 3, 2017 at 2:15 PM, srishti sharma [off-list ref] wrote:

quoted

I ran perl scripts/checkpatch.pl -f drivers/staging/comedi/* | less
for the file comedi_buf.o there is one error , it says
ERROR: Does not appear to be a unified-diff format patch

Hi Srishti,

The argument to checkpatch should be a patch, not the contents of a
directory. Please make a patch like so:

$ diff -u file.original file.modified > changes.patch
$ checkpatch.pl changes.patch

A "source code file" (and thus the content of a directory) is actually ok for
the checkpatch script when using the '-f' option. It would be silly to format
a patch only because you want to use checkpatch on it.

Guru Das Srinagesh.

quoted

quoted

If it's an *.o file then perhaps it's output from a compiler and not a
text file that checkpatch could usefully look at.

--
Jim

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies