skb_clone related query
From: Jeff Haran <hidden>
Date: 2016-01-05 17:22:52
-----Original Message----- From: kernelnewbies-bounces at kernelnewbies.org [mailto:kernelnewbies- bounces at kernelnewbies.org] On Behalf Of pavi1729 Sent: Monday, January 04, 2016 10:12 PM To: Jeff Haran Cc: kernelnewbies at kernelnewbies.org Subject: Re: skb_clone related query Jeff, I have submitte a fix for the same on linux-usb and netdev mailing list. Just waiting for review. Please review the same. http://www.spinics.net/lists/netdev/msg358605.html Cheers, Pavi
The logic looks right to me, though I think a style Nazi might object to the lack of a space between the "if" the leading parenthesis. If it was me I'd put some braces around the call to dev_kfree_skb_any(), though I don't know if checkpatch.pl would complain about that one or not. Jeff Haran