Thread (3 messages) 3 messages, 3 authors, 2015-01-05

Question on checpatch.pl warning -- possible unnecessary 'out of memory' message.

From: Leon Romanovsky <hidden>
Date: 2015-01-05 09:49:57

Hi Bas,
All instances of this warning refer to usage of alloc_skb using the
GFP_ATOMIC flag. Why does checkpatch show this warning? Is it not good
practice to _always_ check whether allocation succeeded or not?

I hope someone can explain the nature of this warning and, if right,
what it should look like.
I suggest you to take a look at the following thread
https://lkml.org/lkml/2014/6/10/382
As a short summary to that discussion:
1. You should check the NULL pointer.
2. You shouldn't print the error.

With kind regards,

Bas Peters



_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


-- 
Leon Romanovsky | Independent Linux Consultant
        www.leon.nu | leon at leon.nu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help