Thread (6 messages) 6 messages, 4 authors, 2014-08-14
STALE4353d

[PATCH] usb: Fix switch statement in ohci-tmio.c

From: Nick Krause <hidden>
Date: 2014-08-14 18:06:32

On Thu, Aug 14, 2014 at 2:05 PM, Nicholas Krause [off-list ref] wrote:
quoted hunk ↗ jump to hunk
I am fixing the bug on at the link, https://bugzilla.kernel.org/show_bug.cgi?id=79931.
This bug report states that in the function, tmio_hc_stop the switch has no needed breaks.
Further more this patch fixes this bug by adding the needed breaks.

Signed-off-by: Nicholas Krause <redacted>
---
 drivers/usb/host/ohci-tmio.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c
index bb40958..d2b5382 100644
--- a/drivers/usb/host/ohci-tmio.c
+++ b/drivers/usb/host/ohci-tmio.c
@@ -100,12 +100,16 @@ static void tmio_stop_hc(struct platform_device *dev)
        switch (ohci->num_ports) {
                default:
                        dev_err(&dev->dev, "Unsupported amount of ports: %d\n", ohci->num_ports);
+                       break;
                case 3:
                        pm |= CCR_PM_USBPW3;
+                       break;
                case 2:
                        pm |= CCR_PM_USBPW2;
+                       break;
                case 1:
                        pm |= CCR_PM_USBPW1;
+                       break;
        }
        tmio_iowrite8(0, tmio->ccr + CCR_INTC);
        tmio_iowrite8(0, tmio->ccr + CCR_ILME);
--
1.9.1
If someone wants to send out this patch for me,that would be great :).
Nick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help