Thread (8 messages) 8 messages, 5 authors, 2013-10-11

What to do with branches after submitting patches?

From: prabhakar.csengg@gmail.com (Prabhakar Lad)
Date: 2013-10-11 10:25:45

On Fri, Oct 11, 2013 at 3:55 PM, Prabhakar Lad
[off-list ref] wrote:
On Fri, Oct 11, 2013 at 3:34 PM, Mandeep Sandhu
[off-list ref] wrote:
quoted
quoted
quoted
Is it possible to use a github repository and just send a "please pull
from git at github.com...." message to the kernel mailinglist, or will I
be beaten for this?
You cannot directly send a pull request until the patches are reviewed,
once the the driver maintainer and other folks in the ML are happy, the
maintainer will pull your patches and get it merged in mainline kernel.

If using github, I think send pull requests is a way to initiate a review.
It does not mean that that pull request will be merged as-is. As you point
out, if there are review comments, the reviewee will address those comments
and send another pull request till the reviewer is satisfied. After that the
reviewer just has to 'merge' the latest pull request.
For reviewing patches on the mailing list you don't send pull request,
! patches needs
to be sent to ML to be reviewed !.

For example look at [1] which is pull request to Linus. The pull request will
just have the patch description(it doesnt have the diff), and the link
to pull the patches from. People dont have time to go to your link and
review the
patches there and reply on your pull request.
"So you need to send patches to ML for review and not pull request"
Ahh missed the link.

[1] http://lkml.indiana.edu/hypermail/linux/kernel/1307.0/02639.html

 Thanks,
 --Prabhakar Lad
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help