Etiquette of submitting patches for fixing coding style.
From: Eugene Voronkov <hidden>
Date: 2012-10-26 20:17:34
On Fri, Oct 26, 2012 at 5:38 AM, Sumeet pawnikar [off-list ref]wrote:
On Fri, Oct 26, 2012 at 1:57 AM, Eugene Voronkov < eugene.voronkov at gmail.com> wrote:quoted
I watched Kroah-Hartman's video[1] on submitting patches where he walks through the process of fixing coding style. I feel like this would be a good way for me to jump into the process but I need more information. At what point do code style patches stop being more trouble then they're worth to the maintainers? For example, running checkpatch.pl against all files is showing around 3 non-trivial style violations per file. Would a patch fixing 12 violations across 4 files be worth submitting?quoted
1. http://www.youtube.com/watch?v=LLBrBBImJt4 _______________________________________________ Kernelnewbies mailing list Kernelnewbies at kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies Suggestion would be, divide your single patch in separate individualpatches with respect to functionality/violations fix.
So for example, one patch removes braces from if/else conditionals with single statement. Another patch fixes incorrect spacing. Correct? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20121026/52d88457/attachment.html