Thread (5 messages) 5 messages, 2 authors, 2012-10-04

when to return -EOPNOTSUPP in _ioctl in a driver

From: Luis R. Rodriguez <hidden>
Date: 2012-10-04 07:38:46

On Thu, Oct 4, 2012 at 12:29 AM, devendra.aaru [off-list ref] wrote:
actually i see it in drivers/staging/csr/

this is in netdev.c

here they do the below way

csr_xxx_ioctl(....)
{
          int ret;

          ret = -EOPNOTSUPP;

          return ret;
}

if the ioctl just needs to say that i am not going to support ioctl,
then why we give the function address in the netdev_ops?
You're right, you should not have to. This is a staging driver though
so the quality is not as good as a sane driver should look like, hence
staging. Send a patch :)
as i understood from your reply that the dev_ioctl returns -EOPNOTSUPP
when theres' no ioctl pointer registered in netdev_ops

am i right?
Yup.

  Luis
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help