How to create patch for checkpatch.pl cleanups

By one thing per patch you mean that I can correct say for example all the 80 char per line warnings in a single file as a patch?

Kashyap Gada



________________________________
 From: Greg KH [off-list ref]
To: Daniel Baluta <redacted> 
Cc: kashyap gada <redacted>; "kernelnewbies at kernelnewbies.org" <redacted> 
Sent: Sunday, 5 February 2012 10:51 PM
Subject: Re: How to create patch for checkpatch.pl cleanups
 
On Sun, Feb 05, 2012 at 11:10:29PM +0200, Daniel Baluta wrote:

On Sun, Feb 5, 2012 at 11:00 PM, kashyap gada [off-list ref] wrote:

quoted

Hello Linux Newbies, I'm one too. I was looking out for some clean up work
and I ran the checkpatch.pl script. I came across a file with some 400
errors and 200 warnings. Now there were bunch of 80 char per line warning ,
braces and related things. I don't want to be sending patches for each and
every error or warning I fix as it becomes tedious and If i send lots of
correction patches in one go the kernel maintainers wont accept it. I want
to know Can we correct all similar errors or warnings in one patch? or
series of patches?

Regarding 80 chars per line issues, people are discussing right now
on increasing the limit to 100. See [1].

For the other issues, just send a patch with all the changes. It should
be fine since you are modifying one single file.

No, please break it up into "one thing per patch" to make it easy to
review, otherwise it will be ignored and/or rejected.

Also realize that a lot of subsystem maintainers do not like these types
of patches, outside of the drivers/staging/ area, so you might want to
ask the subsystem developers if they will take this type of work before
you do it.

greg k-h
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20120206/cf27f85d/attachment-0001.html