Thread (3 messages) 3 messages, 3 authors, 2022-01-06
STALE1606d

[PATCH] trace: remove unneeded initialization in __trace_uprobe_create()

From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date: 2021-12-27 12:53:24
Also in: lkml
Subsystem: the rest, tracing · Maintainers: Linus Torvalds, Steven Rostedt, Masami Hiramatsu

There is no need to initialize ret with 0, as all the early error branches
simply return constant values, and the default path always reaches
ret = kern_path(filename, LOOKUP_FOLLOW, &path), which will reset ret
before the initial value was ever used.

Remove this unneeded initialization and keep the code succinct.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 kernel/trace/trace_uprobe.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 5921951a0d5c..9da10c5efdce 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -548,7 +548,6 @@ static int __trace_uprobe_create(int argc, const char **argv)
 	bool is_return = false;
 	int i, ret;
 
-	ret = 0;
 	ref_ctr_offset = 0;
 
 	switch (argv[0][0]) {
-- 
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help