Re: [PATCH][next] ksmbd: add missing assignments to ret on ndr_read_int64 read calls
From: Namjae Jeon <linkinjeon@kernel.org>
Date: 2021-09-06 23:31:21
Also in:
linux-cifs, lkml
2021-09-06 22:44 GMT+09:00, Colin King [off-list ref]:
From: Colin Ian King <redacted>
Currently there are two ndr_read_int64 calls where ret is being checked
for failure but ret is not being assigned a return value from the call.
Static analyis is reporting the checks on ret as dead code. Fix this.
Addresses-Coverity: ("Logical dead code")
Fixes: 303fff2b8c77 ("ksmbd: add validation for ndr read/write functions")
Signed-off-by: Colin Ian King <redacted>Applied it to my queue. I will send it to Steve after testing. Thanks for your patch!