Re: [PATCH bpf-next v3 2/2] libbpf: Fix the possible memory leak caused by obj->kconfig
From: Shuyi Cheng <hidden>
Date: 2021-07-11 01:27:26
Also in:
bpf, lkml, netdev
On 7/10/21 10:42 PM, Dan Carpenter wrote:
On Fri, Jul 09, 2021 at 10:47:53AM +0800, Shuyi Cheng wrote:quoted
When obj->kconfig is NULL, ERR_PTR(-ENOMEM) should not be returned directly, err=-ENOMEM should be set, and then goto out.The commit message needs to say what the problem is that the patch is fixing. Here is a better commit message: [PATCH bpf-next v3 2/2] libbpf: Fix the possible memory leak on error If the strdup() fails then we need to call bpf_object__close(obj) to avoid a resource leak. Add a Fixes tag as well.
Agree, Thanks. After Andrii reviews the patch, I will resend a new patch. regards, Shuyi
regards, dan carpenter