Re: [PATCH] ocfs2: remove an unnecessary condition
From: Joseph Qi <joseph.qi@linux.alibaba.com>
Date: 2021-07-12 01:46:56
Also in:
ocfs2-devel
On 7/8/21 10:16 PM, Dan Carpenter wrote:
The case where "tmp_oh" is NULL is handled at the start of the function. At this point we know it's non-NULL so this will always return 1. Signed-off-by: Dan Carpenter <redacted>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
quoted hunk ↗ jump to hunk
--- fs/ocfs2/dlmglue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 48fd369c29a4..33fbdc823278 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c@@ -2721,7 +2721,7 @@ int ocfs2_inode_lock_tracker(struct inode *inode, return status; } } - return tmp_oh ? 1 : 0; + return 1; } void ocfs2_inode_unlock_tracker(struct inode *inode,