Thread (2 messages) 2 messages, 2 authors, 2021-06-24

Re: [PATCH] nilfs2: remove redundant continue statement in a while-loop

From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Date: 2021-06-24 17:34:54
Also in: lkml

Thank you.  This change is correct also in view of the expected
behavior of the function
(it really is unnecessary).
I will send this to upstream.

Regards,
Ryusuke Konishi

On Mon, Jun 21, 2021 at 7:05 PM Colin King [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Colin Ian King <redacted>

The continue statement at the end of the while-loop is redundant,
remove it.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <redacted>
---
 fs/nilfs2/btree.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c
index f42ab57201e7..ab9ec073330f 100644
--- a/fs/nilfs2/btree.c
+++ b/fs/nilfs2/btree.c
@@ -738,7 +738,6 @@ static int nilfs_btree_lookup_contig(const struct nilfs_bmap *btree,
                        if (ptr2 != ptr + cnt || ++cnt == maxblocks)
                                goto end;
                        index++;
-                       continue;
                }
                if (level == maxlevel)
                        break;
--
2.31.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help