Re: [PATCH] mm: thp: fix a double unlock bug

From
Dan Carpenter <hidden>
Date
2021-06-01 10:43:59
Also in
linux-mm, lkml
Reply to
Mel Gorman, 2021-06-01
On Tue, Jun 01, 2021 at 11:08:49AM +0100, Mel Gorman wrote:
On Tue, Jun 01, 2021 at 12:24:09PM +0300, Dan Carpenter wrote:
quoted
We're supposed to be holding the "vmf->ptl" spin_lock when we goto
out_map.  The lock is dropped after if finishes cleaning up.

Fixes: 9aff7b33c74a ("mm: thp: refactor NUMA fault handling")
Signed-off-by: Dan Carpenter <redacted>
Ouch.

Acked-by: Mel Gorman <mgorman@suse.de>

However, that git commit is not stable. Instead of Fixes: I would
suggest renaming the patch to "mm: thp: refactor NUMA fault handling
-fix" and replacing Fixes with "This patch is a fix to the mmotm patch
mm-thp-refactor-numa-fault-handling.patch". Andrew usually slots that
into the correct place in his quilt series and collapses the fixes before
sending to Linus which works better with bisection.
I know that these normally get folded in, but I assumed that Andrew
would want the Fixes tag so that he could fold them in automatically
using a mutt alias. #OneClickShopping

regards,
dan carpenter
Thread (4 messages) 4 messages, 3 authors, last reply 2021-06-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help