Thread (3 messages) 3 messages, 3 authors, 2021-06-21

Re: [PATCH net-next] net/smc: Fix ENODATA tests in smc_nl_get_fback_stats()

From: Guvenc Gulce <hidden>
Date: 2021-06-21 17:03:00
Also in: linux-s390, netdev


On 19/06/2021 15:50, Dan Carpenter wrote:
quoted hunk ↗ jump to hunk
These functions return negative ENODATA but the minus sign was left out
in the tests.

Fixes: f0dd7bf5e330 ("net/smc: Add netlink support for SMC fallback statistics")
Signed-off-by: Dan Carpenter <redacted>
---
  net/smc/smc_stats.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/smc/smc_stats.c b/net/smc/smc_stats.c
index 614013e3b574..e80e34f7ac15 100644
--- a/net/smc/smc_stats.c
+++ b/net/smc/smc_stats.c
@@ -393,17 +393,17 @@ int smc_nl_get_fback_stats(struct sk_buff *skb, struct netlink_callback *cb)
  			continue;
  		if (!skip_serv) {
  			rc_srv = smc_nl_get_fback_details(skb, cb, k, is_srv);
-			if (rc_srv && rc_srv != ENODATA)
+			if (rc_srv && rc_srv != -ENODATA)
  				break;
  		} else {
  			skip_serv = 0;
  		}
  		rc_clnt = smc_nl_get_fback_details(skb, cb, k, !is_srv);
-		if (rc_clnt && rc_clnt != ENODATA) {
+		if (rc_clnt && rc_clnt != -ENODATA) {
  			skip_serv = 1;
  			break;
  		}
-		if (rc_clnt == ENODATA && rc_srv == ENODATA)
+		if (rc_clnt == -ENODATA && rc_srv == -ENODATA)
  			break;
  	}
  	mutex_unlock(&net->smc.mutex_fback_rsn);
Acked-by: Guvenc Gulce <redacted>

Thanks for preparing the fix.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help