Thread (17 messages) 17 messages, 8 authors, 2021-03-19

Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call

From: Colin Ian King <hidden>
Date: 2021-03-19 15:56:57
Also in: linux-block, lkml

On 19/03/2021 15:54, Dan Schatzberg wrote:
On Thu, Mar 18, 2021 at 03:16:26PM +0000, Colin King wrote:
quoted
From: Colin Ian King <redacted>

The 3rd argument to alloc_workqueue should be the max_active count,
however currently it is the lo->lo_number that is intended for the
loop%d number. Fix this by adding in the missing max_active count.
Thanks for catching this Colin. I'm fairly new to kernel development.
Is there some tool I could have run locally to catch this?
I'm using Coverity to find these issues. There is a free version [1],
but the one I use is licensed and has the scan level turned up quite
high to catch more issues than the free service.

Refs: [1] https://scan.coverity.com/projects/linux-next-weekly-scan

Colin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help