Re: [PATCH][next] i3c: master: svc: remove redundant assignment to cmd->read_len
From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: 2021-03-02 17:43:38
Also in:
linux-i3c, lkml
From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: 2021-03-02 17:43:38
Also in:
linux-i3c, lkml
Colin King [off-list ref] wrote on Wed, 24 Feb 2021 15:13:49 +0000:
From: Colin Ian King <redacted> The assignment of xfer_len to cmd->read_len appears to be redundant as the next statement re-assigns the value 0 to it. Clean up the code by removing the redundant first assignment. Addresses-Coverity: ("Unused value") Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Signed-off-by: Colin Ian King <redacted> --- drivers/i3c/master/svc-i3c-master.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 8d990696676e..1f6ba4221817 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c@@ -1124,7 +1124,6 @@ static int svc_i3c_master_send_direct_ccc_cmd(struct svc_i3c_master *master, cmd->in = NULL; cmd->out = &ccc->id; cmd->len = 1; - cmd->read_len = xfer_len; cmd->read_len = 0; cmd->continued = true;
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl