Re: [PATCH v2] ath11k: fix a locking bug in ath11k_mac_op_start()
From: Kalle Valo <hidden>
Date: 2021-02-10 07:46:27
Also in:
linux-wireless
From: Kalle Valo <hidden>
Date: 2021-02-10 07:46:27
Also in:
linux-wireless
Dan Carpenter [off-list ref] wrote:
This error path leads to a Smatch warning:
drivers/net/wireless/ath/ath11k/mac.c:4269 ath11k_mac_op_start()
error: double unlocked '&ar->conf_mutex' (orig line 4251)
We're not holding the lock when we do the "goto err;" so it leads to a
double unlock. The fix is to hold the lock for a little longer.
Fixes: c83c500b55b6 ("ath11k: enable idle power save mode")
Signed-off-by: Dan Carpenter <redacted>
[kvalo@codeaurora.org: move also rcu_assign_pointer() call]
Signed-off-by: Kalle Valo <redacted>Patch applied to ath-next branch of ath.git, thanks. c202e2ebe1dc ath11k: fix a locking bug in ath11k_mac_op_start() -- https://patchwork.kernel.org/project/linux-wireless/patch/YBk4GoeE+yc0wlJH@mwanda/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches