Thread (1 message) 1 message, 1 author, 2018-02-07

Re: [PATCH] mm: swap: make pointer swap_avail_heads static

From: Huang, Ying <hidden>
Date: 2018-02-07 00:38:40
Also in: linux-mm

Colin King [off-list ref] writes:
From: Colin Ian King <redacted>

The pointer swap_avail_heads is local to the source and does not need
to be in global scope, so make it static.

Cleans up sparse warning:
mm/swapfile.c:88:19: warning: symbol 'swap_avail_heads' was not
declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
Acked-by: "Huang, Ying" <redacted>

Best Regards,
Huang, Ying
quoted hunk
---
 mm/swapfile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 006047b16814..0d00471af98b 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -85,7 +85,7 @@ PLIST_HEAD(swap_active_head);
  * is held and the locking order requires swap_lock to be taken
  * before any swap_info_struct->lock.
  */
-struct plist_head *swap_avail_heads;
+static struct plist_head *swap_avail_heads;
 static DEFINE_SPINLOCK(swap_avail_lock);
 
 struct swap_info_struct *swap_info[MAX_SWAPFILES];
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help