Re: [PATCH 4/4] char/tpm: Less checks in tpm_ibmvtpm_probe() after error detection
From: SF Markus Elfring <hidden>
Date: 2017-10-19 12:36:54
Also in:
linux-integrity, linuxppc-dev, lkml
From: SF Markus Elfring <hidden>
Date: 2017-10-19 12:36:54
Also in:
linux-integrity, linuxppc-dev, lkml
quoted
@@ -683,13 +683,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,reg_crq_cleanup: dma_unmap_single(dev, ibmvtpm->crq_dma_handle, CRQ_RES_BUF_SIZE, DMA_BIDIRECTIONAL); -cleanup: - if (ibmvtpm) { - if (crq_q->crq_addr) - free_page((unsigned long)crq_q->crq_addr); - kfree(ibmvtpm); - } -I think a single cleanup section is better than many labels that just avoid a single null check.
I proposed to delete two unnecessary condition checks together with an adjustment of jump targets. Regards, Markus