[patch] cpufreq: s3c2416: double free on driver init error path
From: Dan Carpenter <hidden>
Date: 2017-02-07 13:19:06
Also in:
linux-pm, linux-samsung-soc
Subsystem:
arm/samsung s3c, s5p and exynos arm architectures, cpu frequency scaling framework, the rest · Maintainers:
Krzysztof Kozlowski, Peter Griffin, "Rafael J. Wysocki", Viresh Kumar, Linus Torvalds
The "goto err_armclk;" error path already does a clk_put(s3c_freq->hclk);
so this is a double free.
Fixes: 34ee55075265 ("[CPUFREQ] Add S3C2416/S3C2450 cpufreq driver")
Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/cpufreq/s3c2416-cpufreq.c b/drivers/cpufreq/s3c2416-cpufreq.c
index d6d425773fa4..5b2db3c6568f 100644
--- a/drivers/cpufreq/s3c2416-cpufreq.c
+++ b/drivers/cpufreq/s3c2416-cpufreq.c@@ -400,7 +400,6 @@ static int s3c2416_cpufreq_driver_init(struct cpufreq_policy *policy) rate = clk_get_rate(s3c_freq->hclk); if (rate < 133 * 1000 * 1000) { pr_err("cpufreq: HCLK not at 133MHz\n"); - clk_put(s3c_freq->hclk); ret = -EINVAL; goto err_armclk; }