Am 07.12.2016 um 20:06 schrieb Paul Bolle:

On Wed, 2016-12-07 at 14:22 +0300, Dan Carpenter wrote:

quoted

If we can't allocate the resources in gigaset_initdriver() then we
should return -ENOMEM instead of zero.

That's entirely correct.

Agree.

I'll be back (probably tomorrow) after a short test to see whether this really
needs to go into stable. It almost certainly should, but I'd like to first see
the mess the current code leaves behind once gigaset_initdriver() fails before
saying so.

Not much of a mess, I reckon. Everything that has been allocated and
registered up to that point is properly deallocated and unregistered.
The code just fails to tell the kernel that module initialization has
failed, so the module remains loaded even though it can never be
called because it isn't hooked anywhere. That's a nuisance and a
waste of RAM, but not much more.

HTH
Tilman

-- 
Tilman Schmidt                              E-Mail: tilman@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.