--- a/arch/x86/platform/intel-mid/sfi.c

quoted

quoted

+++ b/arch/x86/platform/intel-mid/sfi.c

@@ -335,9 +335,12 @@ static void __init sfi_handle_ipc_dev(struct

sfi_device_table_entry *pentry,
  
  	pr_debug("IPC bus, name = %16.16s, irq = 0x%2x\n",
  		pentry->name, pentry->irq);
+
  	pdata = intel_mid_sfi_get_pdata(dev, pentry);
-	if (IS_ERR(pdata))
+	if (IS_ERR(pdata)) {
+		pr_err("ipc_device: %s: invalid platform data\n",
pentry->name);
  		return;
+	}

This is actually needs more work. We have duplication in sfi.c and
platform_ipc.c.

Yes. But platform_ipc.c implements custom ipc handler for audio ipc 
device. Even though there are duplications between custom handler and 
generic handler in sfi.c, I think its bit early to optimize this. I 
think we should revisit this once we have one more implementation of 
custom ipc handler.