[patch] qla4xxx: remove some bogus casts
From: Dan Carpenter <hidden>
Date: 2015-08-17 14:37:09
Also in:
linux-scsi
Subsystem:
qlogic qla4xxx iscsi driver, scsi subsystem, the rest · Maintainers:
Nilesh Javali, Manish Rangankar, "James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds
These casts are wrong and unnecessary. They annoy static checkers because they imply we are planning to write sizeof(long) bytes to a sizeof(u32) buffer which would corrupt memory. Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c
index 4180d6d..d97ea5d 100644
--- a/drivers/scsi/qla4xxx/ql4_init.c
+++ b/drivers/scsi/qla4xxx/ql4_init.c@@ -101,19 +101,13 @@ int qla4xxx_init_rings(struct scsi_qla_host *ha) ha->response_ptr = &ha->response_ring[ha->response_out]; if (is_qla8022(ha)) { - writel(0, - (unsigned long __iomem *)&ha->qla4_82xx_reg->req_q_out); - writel(0, - (unsigned long __iomem *)&ha->qla4_82xx_reg->rsp_q_in); - writel(0, - (unsigned long __iomem *)&ha->qla4_82xx_reg->rsp_q_out); + writel(0, &ha->qla4_82xx_reg->req_q_out); + writel(0, &ha->qla4_82xx_reg->rsp_q_in); + writel(0, &ha->qla4_82xx_reg->rsp_q_out); } else if (is_qla8032(ha) || is_qla8042(ha)) { - writel(0, - (unsigned long __iomem *)&ha->qla4_83xx_reg->req_q_in); - writel(0, - (unsigned long __iomem *)&ha->qla4_83xx_reg->rsp_q_in); - writel(0, - (unsigned long __iomem *)&ha->qla4_83xx_reg->rsp_q_out); + writel(0, &ha->qla4_83xx_reg->req_q_in); + writel(0, &ha->qla4_83xx_reg->rsp_q_in); + writel(0, &ha->qla4_83xx_reg->rsp_q_out); } else { /* * Initialize DMA Shadow registers. The firmware is really