Thread (15 messages) 15 messages, 5 authors, 2014-08-26

Re: [PATCH 6/7] video: fbdev: sis: delete double assignment

From: Tomi Valkeinen <hidden>
Date: 2014-08-26 10:52:14
Also in: linux-fbdev, lkml

On 24/08/14 21:21, Geert Uytterhoeven wrote:
On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall [off-list ref] wrote:
quoted
---
The patches in this series do not depend on each other.

This changes the semantics of the code and is not tested.
Hence I think you should change the subject of the patch, so it's obvious
some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment".
Well, to me "fix double assignment" sounds the same as "delete double
assignment".

Looking at the code, I think what's done here is "fix 1280x768 panel
timings".

I can apply this and do the change to subject, if nobody complains.

 Tomi

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help