Thread (11 messages) 11 messages, 5 authors, 2012-12-03

Re: [PATCH 4/6] scsi: megaraid: remove a useless call to memset().

From: adam radford <aradford@gmail.com>
Date: 2012-12-03 22:27:10
Also in: linux-scsi, lkml

On Sat, Dec 1, 2012 at 6:40 PM, Cyril Roelandt [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This call is followed by a call to memcpy() on the same memory area, so it can
be safely removed.

Signed-off-by: Cyril Roelandt <redacted>
---
 drivers/scsi/megaraid/megaraid_sas_fusion.c |    2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 74030af..71cc3eb 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -1028,8 +1028,6 @@ map_cmd_status(struct megasas_cmd_fusion *cmd, u8 status, u8 ext_status)

                cmd->scmd->result = (DID_OK << 16) | ext_status;
                if (ext_status = SAM_STAT_CHECK_CONDITION) {
-                       memset(cmd->scmd->sense_buffer, 0,
-                              SCSI_SENSE_BUFFERSIZE);
                        memcpy(cmd->scmd->sense_buffer, cmd->sense,
                               SCSI_SENSE_BUFFERSIZE);
                        cmd->scmd->result |= DRIVER_SENSE << 24;
--
Acked-by: Adam Radford <aradford@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help