Thread (14 messages) 14 messages, 5 authors, 2012-12-03

Re: [patch v3] x86, UV: integer wrap bug in uv_hub_ipi_value()

From: Dan Carpenter <hidden>
Date: 2012-12-02 17:35:49
Also in: lkml

On Sun, Dec 02, 2012 at 08:28:43PM +0300, Dan Carpenter wrote:
This is a static checker fix.  The problem is that we store the bits
from "uv_apicid_hibits" into "apicid" (the high 16 bits) but then we
shift it 16 bit to the left.  "apicid" is an int so it wraps and we lose
them.

I have also simplified uv_wakeup_secondary() a little based on a
suggestion.
This was supposed to say "suggestions from Walter Harms." but I
pressed "u" in vim instead of "i" because they are next to each
other so that that got deleted.  @%$@#$%@%$.  I'll resend.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help