Thread (10 messages) 10 messages, 4 authors, 2012-08-28

Re: [PATCH 4/6] drivers/usb/host/ohci-nxp.c: adjust inconsistent IS_ERR and PTR_ERR

From: Alan Stern <stern@rowland.harvard.edu>
Date: 2012-08-27 14:39:01
Also in: lkml

On Sat, 25 Aug 2012, Julia Lawall wrote:
From: Julia Lawall <redacted>

Change the call to PTR_ERR to access the value just tested by IS_ERR.
quoted hunk ↗ jump to hunk
Signed-off-by: Julia Lawall <redacted>

---
 drivers/usb/host/ohci-nxp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
index a446386..c60066a 100644
--- a/drivers/usb/host/ohci-nxp.c
+++ b/drivers/usb/host/ohci-nxp.c
@@ -355,7 +355,7 @@ static int __devinit usb_hcd_nxp_probe(struct platform_device *pdev)
 	usb_otg_clk = clk_get(&pdev->dev, "ck_usb_otg");
 	if (IS_ERR(usb_otg_clk)) {
 		dev_err(&pdev->dev, "failed to acquire USB DEV Clock\n");
-		ret = PTR_ERR(usb_dev_clk);
+		ret = PTR_ERR(usb_otg_clk);
 		goto out6;
 	}
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help