Thread (26 messages) 26 messages, 7 authors, 2012-09-01

Re: [PATCH 5/13] arch/arm: use clk_prepare_enable and clk_disable_unprepare

From: Pankaj Jangra <hidden>
Date: 2012-08-27 05:57:35
Also in: linux-arm-kernel, lkml

Hi,

On Sun, Aug 26, 2012 at 9:30 PM, Julia Lawall [off-list ref] wrote:
From: Julia Lawall <redacted>

Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and
clk_enable, and clk_disable and clk_unprepare.  They make the code more
concise, and ensure that clk_unprepare is called when clk_enable fails.

A simplified version of the semantic patch that introduces calls to these
functions is as follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

- clk_prepare(e);
- clk_enable(e);
+ clk_prepare_enable(e);

@@
expression e;
@@

- clk_disable(e);
- clk_unprepare(e);
+ clk_disable_unprepare(e);
// </smpl>

Signed-off-by: Julia Lawall <redacted>

---
 arch/arm/common/sa1111.c   |    3 +--
 arch/arm/common/timer-sp.c |   16 ++++------------
 arch/arm/kernel/smp_twd.c  |   13 +++----------
 3 files changed, 8 insertions(+), 24 deletions(-)
Reviewed-by: Pankaj Jangra <redacted>

Regards,
Pankaj Jangra
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help