Re: [PATCH 5/7] drivers/iommu/tegra-smmu.c: remove invalid reference to list iterator variable
From: Stephen Warren <hidden>
Date: 2012-07-23 17:59:28
Also in:
linux-iommu, lkml
From: Stephen Warren <hidden>
Date: 2012-07-23 17:59:28
Also in:
linux-iommu, lkml
On 07/08/2012 05:37 AM, Julia Lawall wrote:
From: Julia Lawall <redacted>
Julia, It looks like this patch hasn't seen any replies since you didn't CC the maintainers of this code. I've CC'd them now.
If list_for_each_entry, etc complete a traversal of the list, the iterator variable ends up pointing to an address at an offset from the list head, and not a meaningful structure. Thus this value should not be used after the end of the iterator. Replace c->dev by dev, which is the value that c->dev has been compared to. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). Signed-off-by: Julia Lawall <redacted>
Acked-by: Stephen Warren <redacted>