Thread (23 messages) flat view 23 messages, 8 authors, 2012-06-12

Re: [PATCH 1/7] drivers/ide/ide-cs.c: adjust suspicious bit operation

From: David Miller <davem@davemloft.net>
Date: 2012-06-12 22:52:20
Also in: linux-ide, lkml

From: Julia Lawall <redacted>
Date: Tue, 12 Jun 2012 10:17:25 -0400 (EDT)
From: Julia Lawall <redacted>

IO_DATA_PATH_WIDTH_8 is 0, so a bit-and with it is always false.  The
value IO_DATA_PATH_WIDTH covers the bits of the IO_DATA_PATH constants, so
first pick those bits and then make the test using !=.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help