Re: [PATCH 1/2] arch/powerpc/platforms/cell/iommu.c: add missing of_node_put

On Sunday 21 August 2011, Julia Lawall wrote:

From: Julia Lawall <redacted>

np is initialized to the result of calling a function that calls
of_node_get, so of_node_put should be called before the pointer is dropped.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e,e1,e2;
@@

* e = \(of_find_node_by_type\|of_find_node_by_name\)(...)
  ... when != of_node_put(e)
      when != true e = NULL
      when != e2 = e
  e = e1
// </smpl>

Signed-off-by: Julia Lawall <redacted>

Acked-by: Arnd Bergmann <arnd@arndb.de>