Re: [patch] Input: uinput - reversed test in uinput_setup_device()
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2011-02-18 16:31:31
Also in:
linux-input
On Fri, Feb 18, 2011 at 12:17:57PM +0300, Dan Carpenter wrote:
The test here is reversed. It should be if (IS_ERR()) instead of if (!IS_ERR()).
Awww, crap... Applied, thanks Dan.
quoted hunk ↗ jump to hunk
Signed-off-by: Dan Carpenter <redacted>diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c index 7f8331f..364bdf4 100644 --- a/drivers/input/misc/uinput.c +++ b/drivers/input/misc/uinput.c@@ -362,7 +362,7 @@ static int uinput_setup_device(struct uinput_device *udev, const char __user *bu dev = udev->dev; user_dev = memdup_user(buffer, sizeof(struct uinput_user_dev)); - if (!IS_ERR(user_dev)) + if (IS_ERR(user_dev)) return PTR_ERR(user_dev); udev->ff_effects_max = user_dev->ff_effects_max;
-- Dmitry