Thread (9 messages) 9 messages, 6 authors, 2011-02-20

Re: [patch -next] x86, microcode, AMD: signedness bug in

From: Dan Carpenter <hidden>
Date: 2011-02-20 13:10:11
Also in: lkml

On Sun, Feb 20, 2011 at 02:02:14PM +0100, Ingo Molnar wrote:
* Dan Carpenter [off-list ref] wrote:
quoted
install_equiv_cpu_table() returns type int.  It uses negative error
codes so using an unsigned type breaks the error handling.
How did you notice this btw - did GCC throw a warning?
It's a smatch warning.

arch/x86/kernel/microcode_amd.c +256 generic_load_microcode(12)
	warn: unsigned 'offset' is never less than zero.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help