Thread (13 messages) 13 messages, 7 authors, 2011-04-08

Re: [PATCH 2/5] drivers/char/hw_random/omap-rng.c: Convert

From: Matt Mackall <hidden>
Date: 2011-02-14 22:42:32
Also in: lkml

On Sun, 2011-02-13 at 13:12 +0100, Julia Lawall wrote:
Request_region should be used with release_region, not release_resource.

The local variable mem, storing the result of request_mem_region, is
dropped and instead the pointer res is stored in the drvdata field of the
platform device.  This information is retrieved in omap_rng_remove to
release the region.  The drvdata field is not used elsewhere.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
Looks ok to me, Herbert?

-- 
Mathematics is the supreme nostalgia of our time.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help