Thread (20 messages) flat view 20 messages, 3 authors, 2021-08-13

Re: [PATCH 4/6] block: clear BIO_PERCPU_CACHE flag if polling isn't supported

From: Keith Busch <kbusch@kernel.org>
Date: 2021-08-12 17:31:49
Also in: linux-block

On Thu, Aug 12, 2021 at 09:41:47AM -0600, Jens Axboe wrote:
-	if (!test_bit(QUEUE_FLAG_POLL, &q->queue_flags))
+	if (!test_bit(QUEUE_FLAG_POLL, &q->queue_flags)) {
+		/* can't support alloc cache if we turn off polling */
+		bio_clear_flag(bio, BIO_PERCPU_CACHE);
 		bio->bi_opf &= ~REQ_HIPRI;
+	}
It looks like you should also clear BIO_PERCPU_CACHE if this bio gets
split in blk_bio_segment_split().
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help