On Wed, Jul 7, 2021 at 5:28 AM Dmitry Kadashev [off-list ref] wrote:

This started out as an attempt to add mkdirat support to io_uring which
is heavily based on renameat() / unlinkat() support.

Ok, sorry for having made you go through all the different versions,
but I like the new series and think it's a marked improvement.

I did send out a few comments to the individual patches that I think
it can all now be made to be even more legible by avoiding some of the
goto spaghetti, but I think that would be a series on top.

(And I'd like to note again that I based all that on just reading the
patches, so there may be something there that makes it not work well).

One final request: can you keep the fs/namei.c patches as one entirely
separate series, and then do the io_uring parts at the end, rather
than intermixing them?

But at least I am generally happy with this version.

Al - please holler now if you see any issues.

               Linus