Thread (26 messages) 26 messages, 6 authors, 2022-02-11

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Protect lockdep functions with #ifdef

From: Namhyung Kim <namhyung@kernel.org>
Date: 2022-02-08 19:23:12
Also in: lkml

Hello,

On Tue, Feb 8, 2022 at 10:51 AM Jani Nikula [off-list ref] wrote:
On Tue, 08 Feb 2022, Namhyung Kim [off-list ref] wrote:
quoted
With upcoming lock tracepoints config, it'd define some of lockdep
functions without enabling CONFIG_LOCKDEP actually.  The existing code
assumes those functions will be removed by the preprocessor but it's
not the case anymore.  Let's protect the code with #ifdef's explicitly.
I don't understand why you can't keep the no-op stubs for
CONFIG_LOCKDEP=n.
Because I want to use the lockdep annotation for other purposes.
But the workqueue lockdep_map was defined under LOCKDEP
only.  Please see the description in the cover letter.

https://lore.kernel.org/all/20220208184208.79303-1-namhyung@kernel.org/ (local)

Thanks,
Namhyung
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help