for_each_crtc_with_valid_output() iterates over every crtc with
connected output. Split it into two loops. This is needed to handle per
output and per crtc cases.
v4->v5
- fix indentation (Mohammed)
Signed-off-by: Michał Grzelak <redacted>
---
tests/intel/kms_ccs.c | 58 +++++++++++++++++++++----------------------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/tests/intel/kms_ccs.c b/tests/intel/kms_ccs.c
index 4d0bda6a78..1a922792c5 100644
--- a/tests/intel/kms_ccs.c
+++ b/tests/intel/kms_ccs.c
@@ -1152,47 +1152,47 @@ static void test_output(data_t *data, const int testnum)
"Older than Xe2 platform needed.\n");
}
- for_each_crtc_with_valid_output(&data->display, crtc,
- data->output) {
- data->crtc = crtc;
- igt_display_reset(&data->display);
+ for_each_connected_output(&data->display, data->output) {
+ for_each_crtc(&data->display, crtc) {
+ if (!igt_crtc_connector_valid(crtc, data->output))
+ continue;
- igt_output_set_crtc(data->output,
- crtc);
- if (!intel_pipe_output_combo_valid(&data->display))
- continue;
+ data->crtc = crtc;
+ igt_display_reset(&data->display);
- igt_dynamic_f("pipe-%s-%s",
- igt_crtc_name(crtc),
- data->output->name) {
- int valid_tests = 0;
+ igt_output_set_crtc(data->output, crtc);
+ if (!intel_pipe_output_combo_valid(&data->display))
+ continue;
- if (data->flags == TEST_RANDOM)
- igt_info("Testing with seed %d\n", data->seed);
+ igt_dynamic_f("pipe-%s-%s", igt_crtc_name(crtc), data->output->name) {
+ int valid_tests = 0;
- if (data->flags & TEST_ALL_PLANES) {
- igt_display_require_output_on_crtc(crtc);
+ if (data->flags == TEST_RANDOM)
+ igt_info("Testing with seed %d\n", data->seed);
- for_each_plane_on_crtc(crtc,
- data->plane) {
- if (skip_plane(data, data->plane))
- continue;
+ if (data->flags & TEST_ALL_PLANES) {
+ igt_display_require_output_on_crtc(crtc);
+ for_each_plane_on_crtc(crtc, data->plane) {
+ if (skip_plane(data, data->plane))
+ continue;
+
+ for (int j = 0; j < ARRAY_SIZE(formats); j++) {
+ data->format = formats[j];
+ valid_tests += test_ccs(data);
+ }
+ }
+ } else {
for (int j = 0; j < ARRAY_SIZE(formats); j++) {
data->format = formats[j];
valid_tests += test_ccs(data);
}
}
- } else {
- for (int j = 0; j < ARRAY_SIZE(formats); j++) {
- data->format = formats[j];
- valid_tests += test_ccs(data);
- }
+ igt_require_f(valid_tests > 0,
+ "no valid tests for %s on pipe %s\n",
+ ccs_modifiers[i].str,
+ igt_crtc_name(crtc));
}
- igt_require_f(valid_tests > 0,
- "no valid tests for %s on pipe %s\n",
- ccs_modifiers[i].str,
- igt_crtc_name(crtc));
}
}
}--
2.45.2