Thread (20 messages) read the whole thread 20 messages, 3 authors, 2021-10-18

Re: [igt-dev] [PATCH i-g-t 7/7] tests/kms_concurrent: Use preferred modes's vrefresh

From: Modem, Bhanuprakash <hidden>
Date: 2021-10-18 05:03:59

From: igt-dev <redacted> On Behalf Of Ville
Syrjala
Sent: Wednesday, October 13, 2021 6:30 PM
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 7/7] tests/kms_concurrent: Use preferred
modes's vrefresh

From: Ville Syrjälä <redacted>

i915 will reject custom modes that don't match the laptop
panel's fixed mode refresh rate. Thus we must generate
our override modes with a matching refresh rate.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4284
Signed-off-by: Ville Syrjälä <redacted>
 
LGTM
Reviewed-by: Bhanuprakash Modem <redacted>

- Bhanu
quoted hunk ↗ jump to hunk
---
 tests/kms_concurrent.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index 085eaa0a630d..1b8f4b04356b 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -240,7 +240,7 @@ get_lowres_mode(data_t *data, const drmModeModeInfo
*mode_default,
 			return igt_memdup(mode, sizeof(*mode));
 	}

-	return igt_std_1024_mode_get(60);
+	return igt_std_1024_mode_get(igt_output_preferred_vrefresh(output));
 }

 static void
--
2.32.0
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help