Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Remove duplicated assignment
From: Dixit, Ashutosh <hidden>
Date: 2021-09-27 16:10:20
On Mon, 27 Sep 2021 04:21:00 -0700, Zbigniew Kempczyński wrote:
quoted hunk ↗ jump to hunk
Due to some changes related in the alignment in the future remove unnecessary assignment. Signed-off-by: Zbigniew Kempczyński <redacted> Cc: Petri Latvala <redacted> Cc: Ashutosh Dixit <redacted> --- lib/intel_batchbuffer.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c index 399d0e990..e3e649ca3 100644 --- a/lib/intel_batchbuffer.c +++ b/lib/intel_batchbuffer.c@@ -2020,9 +2020,6 @@ __intel_bb_add_intel_buf(struct intel_bb *ibb, struct intel_buf *buf,buf->addr.offset, alignment, write); buf->addr.offset = obj->offset; - if (!ibb->enforce_relocs) - obj->alignment = alignment; -
OK so you are saying that the assignment in intel_bb_add_object() is already sufficient. Reviewed-by: Ashutosh Dixit <redacted>
if (igt_list_empty(&buf->link)) {
igt_list_add_tail(&buf->link, &ibb->intel_bufs);
buf->ibb = ibb;
--
2.26.0