Re: [igt-dev] [PATCH i-g-t v3 08/52] lib/huc_copy: Extend huc copy prototype to pass allocator handle

On Wed, Aug 04, 2021 at 05:31:01PM -0700, Dixit, Ashutosh wrote:

On Mon, 26 Jul 2021 12:59:42 -0700, Zbigniew Kempczyński wrote:

quoted

@@ -86,6 +90,21 @@ gen9_huc_copyfunc(int fd,

buf[i++] = MFX_WAIT;

memset(reloc, 0, sizeof(reloc));
+
+	if (ahnd) {
+		obj[0].flags = EXEC_OBJECT_PINNED;
+		obj[1].flags = EXEC_OBJECT_PINNED | EXEC_OBJECT_WRITE;
+		obj[2].flags = EXEC_OBJECT_PINNED;

Don't need | EXEC_OBJECT_SUPPORTS_48B_ADDRESS here?

Otherwise this is:

Reviewed-by: Ashutosh Dixit <redacted>

gen9_emit_huc_virtual_addr_state() currently sets only first dword with
offset (other two buf[(*i)++] = 0; are intact).

This is only used within gem_huc_copy.c and I know offsets passed starts
from 0x0 and won't exceed 32-bit I left it with without 48B_ADDRESS set.

--
Zbigniew