Hi Vidya,

Can you please address the comments in rev 14: https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14


Thanks,
Bhanu

-----Original Message-----
From: Srinivas, Vidya <redacted>
Sent: Thursday, July 8, 2021 7:49 PM
To: Shankar, Uma <redacted>; Modem, Bhanuprakash
[off-list ref]; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
assertion in coverage-vs-premult-vs-none for 6bpc panels

Hello Uma/Bhanu,

https://patchwork.freedesktop.org/patch/443212/?series=90828&rev=15 I have
submitted the patch with adding DSI and skipping the test.
Kindly check and approve if okay.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya
Sent: Thursday, July 8, 2021 7:44 PM
To: Shankar, Uma <redacted>; Modem, Bhanuprakash
[off-list ref]; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
assertion in coverage-vs-premult-vs-none for 6bpc panels

Hello Uma,

Sure, I have already submitted skipping test itself
https://patchwork.freedesktop.org/patch/443207/?series=90828&rev=14
I will add DSI also the same and re-submit. Thank you so much.

Regards
Vidya

-----Original Message-----
From: Shankar, Uma <redacted>
Sent: Thursday, July 8, 2021 7:05 PM
To: Modem, Bhanuprakash <redacted>; Srinivas, Vidya
[off-list ref]; igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip crc
assertion in coverage-vs-premult-vs-none for 6bpc panels

quoted

-----Original Message-----
From: Modem, Bhanuprakash <redacted>
Sent: Thursday, July 8, 2021 5:51 PM
To: Srinivas, Vidya <redacted>;
igt-dev@lists.freedesktop.org; Shankar, Uma [off-list ref]
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip
crc assertion in coverage-vs-premult-vs-none for 6bpc panels

quoted

From: Srinivas, Vidya <redacted>
Sent: Thursday, July 8, 2021 5:03 PM
To: Modem, Bhanuprakash <redacted>; igt-
dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

Hello Bhanu,

No we skip it for all 6bpc. We can skip the test, but as discussed
with Uma, I just skip crc check, not the test.
Kindly suggest further.

If we remove/skip the crc check, I think there is no point in doing
further commits unless we have kernel checkers.

Uma?

I think it's a compromise here,  skip on 6bpc would be ideal here or we need
to have some passing criterion in order to declare this as pass.

We can do the bpc check after the first commit and skip there itself if we
detect 6bpc.This should be better given the constraints. Also Vidya its good
to add MIPI_DSI along with eDP as well since we have some 6bpc MIPI DSI panels
as well.

quoted

quoted

Regards
Vidya

-----Original Message-----
From: Modem, Bhanuprakash <redacted>
Sent: Thursday, July 8, 2021 4:15 PM
To: Srinivas, Vidya <redacted>;
igt-dev@lists.freedesktop.org
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
Skip crc assertion in coverage-vs-premult-vs-none for 6bpc panels

quoted

From: igt-dev <redacted> On Behalf Of
Vidya Srinivas
Sent: Thursday, July 8, 2021 3:01 PM
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Skip
crc assertion in coverage-vs-premult-vs-none for 6bpc panels

Intel Gen11 platforms using 6bpc panels have dithering ON and show
CRC mismatch in coverage-vs-premult-vs-none Doing a crc based test
with dithering is not a great idea as pixels will change due to
the 8bit to 6bits truncation with dithering.

This patch skips the CRC assertion for 6bpc panels. Currently,
there is no better way of fetching the bpc info other than EDID or
display_info. Currently using i915_display_info for the same.
Hence restricting the check to i915 devices only.

Credits-to: Uma Shankar [off-list ref]
Credits-to: Juha-pekka Heikkila [off-list ref]
Credits-to: Modem Bhanuprakash [off-list ref]
Reviewed-by: Uma Shankar <redacted>
Signed-off-by: Vidya Srinivas <redacted>
---
 tests/kms_plane_alpha_blend.c | 43
+++++++++++++++++++++++++++++++++--
 1 file changed, 41 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c

b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..e450e64cb105
100644

--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c

@@ -442,10 +442,42 @@ static void coverage_7efc(data_t *data, enum

pipe pipe, igt_plane_t *plane)  igt_pipe_crc_stop(data->pipe_crc);
 }

+static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
+char buf[4096]; char *str; bool ret; int debugfs_fd;
+drmModeConnector *c; igt_output_t *output =
+igt_get_single_output_for_pipe(display,
+pipe);
+
+if (!is_i915_device(display->drm_fd))
+return false;
+
+c = output->config.connector;
+if (c->connector_type != DRM_MODE_CONNECTOR_eDP) return false;
+
+debugfs_fd = igt_debugfs_dir(display->drm_fd); if (debugfs_fd <
+0) return false;
+
+igt_debugfs_simple_read(debugfs_fd, "i915_display_info", buf,
sizeof(buf));
+
+str = strstr(buf, "bpp=");
+if (str && (strncmp(str, "bpp=18", 6) == 0)) ret = true; else ret
+= false;
+
+close(debugfs_fd);
+return ret;
+}
+
 static void coverage_premult_constant(data_t *data, enum pipe
pipe, igt_plane_t *plane)  {  igt_display_t *display =
&data->display;  igt_crc_t ref_crc = {}, crc = {};
+bool is6bpc = false;

 /* Set a background color on the primary fb for testing */  if
(plane->type != DRM_PLANE_TYPE_PRIMARY) @@ -461,14 +493,21 @@
static void coverage_premult_constant(data_t *data, enum pipe
pipe, igt_plane_t  igt_plane_set_fb(plane, &data->argb_fb_7e);
igt_display_commit2(display, COMMIT_ATOMIC);
igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-igt_assert_crc_equal(&ref_crc, &crc);
+
+/* 6bpc panels have dithering ON and CRC might fail, hence skip
+crc
check */
+is6bpc = is_6bpc(display, pipe);
+if (is6bpc == false)
+igt_assert_crc_equal(&ref_crc, &crc);

We can SKIP here, right? Also no need to run on remaining planes.
Otherwise IGT will report this test result as PASS instead of reporting as

SKIP.

quoted

quoted

igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc
panels\n");


Also, are we going to skip this test on only gen 11? Then we need a
check to perform such.

if (is_i915_device(fd) && intel_gen(intel_get_drm_devid(fd)) == 11)
igt_require_f(!is_6bpc(display, pipe), "Skip test on 6 bpc
panels\n");

quoted

 igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE,

"None");

quoted

quoted

 igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0x7e7e);
igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
igt_display_commit2(display, COMMIT_ATOMIC);
igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &crc);
-igt_assert_crc_equal(&ref_crc, &crc);
+
+/* 6bpc panels have dithering ON and CRC might fail, hence skip
+crc
check */
+if (is6bpc == false)
+igt_assert_crc_equal(&ref_crc, &crc);

 igt_pipe_crc_stop(data->pipe_crc);
 }
--
2.32.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev