Re: [igt-dev] [PATCH i-g-t] tests/kms_content_protection: Skip if not able to create display_hdcp_srm.bin
From: Petri Latvala <hidden>
Date: 2021-06-21 10:38:50
On Mon, Jun 07, 2021 at 05:32:17PM -0700, Khaled Almahallawy wrote:
quoted hunk ↗ jump to hunk
On Chrome devices, SRM subtest fails to create display_hdcp_srm.bin file because Chrome OS rootfs is mounted read-only by default (https://chromium.googlesource.com/chromiumos/docs/+/HEAD/developer_mode.md#disable-verity). The error below is observed in Chrome: (kms_content_protection:9022) DEBUG: Test requirement passed: data.display.is_atomic (kms_content_protection:9022) CRITICAL: Test assertion failure function __real_main720, file ../igt-gpu-tools-1.25/tests/kms_content_protection.c:807: (kms_content_protection:9022) CRITICAL: Failed assertion: ret (kms_content_protection:9022) CRITICAL: Last errno: 9, Bad file descriptor (kms_content_protection:9022) CRITICAL: SRM update failedStack trace: This patch fixes that by checking if the file descriptor returned from the open call is valid and skip if it is not. Cc: Mark Yacoub <redacted> Reported-by: Shawn Lee <redacted> Signed-off-by: Khaled Almahallawy <redacted> --- tests/kms_content_protection.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c index 1d1a439a98fb..3cd279fe5704 100644 --- a/tests/kms_content_protection.c +++ b/tests/kms_content_protection.c@@ -296,6 +296,8 @@ static bool write_srm_as_fw(const __u8 *srm, int len) fd = open("/lib/firmware/display_hdcp_srm.bin", O_WRONLY | O_CREAT, S_IRWXU); + igt_require(fd >= 0);
To help someone reading the logs figure out what's blocking the testing, make this igt_require_f(fd >= 0, "Cannot write SRM binary to /lib/firmware\n"); (Does igt_require print out errno? I forget...) -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev